Re: [patch] irq rewrite

Richard Henderson (rth@cygnus.com)
Tue, 7 Dec 1999 12:01:00 -0800


On Tue, Dec 07, 1999 at 08:00:51PM +0100, Andrea Arcangeli wrote:
> The only thing that Linus can be interested about is the new
> ____cacheline_aligned macro.

You probably want to rename those somehow. I don't know
about you but I find 2_ and 4_ prefixes unintelligable.

Perhaps __struct_cacheline_aligned? I don't really like
it but it's at least descriptiveof how it might be used
differently from the previous x86 macro...

> I am also not 100% sure if
> __gcc_cacheline_aligned works fine with gcc-2.7.2.3 or not.

Does it give a warning? If so it doesn't work, if not it does.

r~