Re: [patch] arch/i386/setup.S bug

From: Chris Noe (stiker@northlink.com)
Date: Wed Jan 05 2000 - 22:00:46 EST


On Wed, 5 Jan 2000, Tigran Aivazian wrote:

> typo - read movsw. And patch had movsw and NOT movsd so it was really a
> typo :)

Damn keyboards always conspiring against us. :)

How about this: use movsd (=movsl in at&t) just like the lines above it
do. Strange that noone has noticed that it was done this way, twice,
above.

Attached is the diff which fixes my screwiness in setup.S and the
inconsistency you noticed in head.S.

Chris Noe
(stiker@northlink.com)

--- linux-2.3.36p6/arch/i386/boot/setup.S.orig Tue Jan 4 09:05:56 2000
+++ linux/arch/i386/boot/setup.S Tue Jan 4 09:12:23 2000
@@ -202,9 +202,9 @@
         xorb %bh, %bh
         movb (497), %bl # get setup sect from bootsect
         subw $4, %bx # LILO loads 4 sectors of setup
- shlw $7, %bx # convert to dwords (1sect=2^7 dwords)
+ shlw $8, %bx # convert to words (1sect=2^8 words)
         movw %bx, %cx
- shrw $2, %bx # convert to segment
+ shrw $3, %bx # convert to segment
         addw $SYSSEG, %bx
         movw %bx, %cs:start_sys_seg
 # Move rest of setup code/data to here

--- linux-2.3.36p6/arch/i386/kernel/head.S.orig Wed Jan 5 21:37:57 2000
+++ linux/arch/i386/kernel/head.S Wed Jan 5 21:38:08 2000
@@ -133,9 +133,9 @@
         movl $ SYMBOL_NAME(empty_zero_page)+2048,%edi
         movzwl CL_OFFSET,%esi
         addl $(CL_BASE_ADDR),%esi
- movl $2048,%ecx
+ movl $512,%ecx
         rep
- movsb
+ movsl
 1:
 #ifdef __SMP__
 checkCPUtype:

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Jan 07 2000 - 21:00:05 EST