Re: Patch for isapnp OOPS [verified fixed]

From: J. Nick Koston (bdraco-lists@darkorb.net)
Date: Mon Jan 10 2000 - 19:05:19 EST


        Great, that fixes the isapnp issue on both my machines.

                Thanks,
                Nick

On Mon, 10 Jan 2000, you wrote:
This appears to fix the oops in isapnp_create_device at boot:

--- linus-2.3.38/drivers/pnp/isapnp.c Mon Jan 10 02:50:24 2000
+++ linux/drivers/pnp/isapnp.c Mon Jan 10 04:13:13 2000
@@ -991,6 +991,7 @@
                        continue;
                if ((card = isapnp_alloc(sizeof(struct pci_bus))) == NULL)
                        continue;
+ INIT_LIST_HEAD(&card->devices);
                card->number = csn;
                card->vendor = (header[1] << 8) | header[0];
                card->device = (header[3] << 8) | header[2];

 I noticed another patch that had the INIT_LIST_HEAD lower down in
the same function: it doesn't work because the card->devices list
head is accessed earlier, in isapnp_create_devices, causing the
oops (that's where EIP points in the oops, anyway).

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

-- 

-----BEGIN PGP PUBLIC KEY BLOCK----- Version: GnuPG v1.0.0 (GNU/Linux) Comment: For info see http://www.gnupg.org

mQGiBDeipvQRBACXRQJi5PCuUa5fYfEMc/LvfbSc3oHghiAn5slOAEdOaHltHTuX nu01FIY/O29sbu1PGqa6hWsaiv8jbUuY/e5YXDGkveA26EX078aqfcomOGWCoY38 8dWgLFd9w/5A+OAi9M4DlSgDguRj3VpXwbS2/YaqmToaVXZxX0eS4TzA6wCg5fBW j30TqUAfZZ5uZ1MGO63wLS8D/2BfJ5IJFoKqKZ1Mr74M0I+IsBvSDfg/9Zp+8iqW 5TnLI9HFfdouCp6Dd1ohKLjJXTwQV34nC4uWR8DKSQYxZsoTt25wg7q+cb5pqSFM j7D10e9rWMP2cjFVVV0sLGXFbShtNRQ/cmrPSqNI1/sucyjeuTdgaiuRg/2gXM+R SrbdBACREZYLW/3RlNrESLd2RFvuPNkiCI2Sta5oeQwnL6dRzX8hX8WuOHqU8NES vGTR9NSkIzzM/9+K539J2Drgtn7QUkz/0FiJejxTmHlu9PoeaKs38mktjJ1T1Bi2 ba+njNmkIiYidlBqli0rT3DeXU9IGFoBMQmLRJ04P7ZS9y4JUbQvSi4gTmljayBL b3N0b24gKEJsdWVEcmFjbykgPGJkcmFjb0BkYXJrb3JiLm5ldD6IVQQTEQIAFQUC N6Km9AMLCgMDFQMCAxYCAQIXgAAKCRCUleWDU9+v9ZXCAKCabKfJOi2/q2uPsyz/ jK6y6Df6IwCePitKxAg8g79xE3tkFNJroOYdgBiIRgQQEQIABgUCN6KvewAKCRDN mLlpIWwdg1mJAJsEznPV3aq6THz0sX4Csr0l9iLgpwCfYihf+FhoIl/hDBfSaEvM OoYzDHy5Ag0EN6KndRAIAM+zDGxzWFH5itH8EDNabOiBOOHWB/y+A76eAErY6E41 nO/0j3gpGr1WfyFW5VRKiElD0+eDBR9bpg7jdrtjdtQiGiDQWsdFHmQQUKU1aIH8 zlyr2fTJveyqZde9eSGiu6Sm9EmO8wBTJhCO4Myq68gyQDBjmzr4qX+EMy1HuYKG QmHvP/YkwfRew5umqrGttu6+ia/AfNzB+SqpYKjv3AE4Aie/BAOugLYT3XaYmg31 bS7b6yYRegGmkhPyTECZ5MoBfG38S6kpVmxHqsozqEBD9GTCRcwXsn/b0CV11nA+ B8MnUvHzUicS9Wv9VLkcNDTAynbzPvx1X3q6DDOYuKMAAwYH/1ud8ye6cgMNuE+Y k9MhjgE60vMCt6iP0+qoGVMcxgvbD5k1z1U3LE61nhhK4jpx4zL7tRbsNJGrxOtS NTAU59UHf+3E/ZecHh2PXrX1achBP7jaXjJ/aE+JTKA8Y48mSC7ZaasVwi/pV3gS y+ptvo8W8lvJREh0YAdPSuGVjyOQ20xENMFxJvuyfGqUHj4RJiNHs3ybkp5NeVo/ KvGKH38now/R0IgFpmh/Ubl50caMF7/SpHbY3N83GP6xAZa8O8L48vFhzG7rkxg9 SkGztoxcukeCsb7TxDhHrX3h9NoyOtjiTZS3oN4jULK9aqtm04RPhkbppfIG/6ac MYjVJACIRgQYEQIABgUCN6KndQAKCRCUleWDU9+v9UvNAJ9D3tvLHsghuyeRT4Fs vJFeHqT86gCdHJx+XXlyLPrNG0ZrB44Q6+a87iw= =Flor -----END PGP PUBLIC KEY BLOCK-----

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Jan 15 2000 - 21:00:17 EST