Bill Wendling wrote:
>
> Also sprach Manfred Spraul:
> } Bill Wendling wrote:
> } >
> } + else
> } + fds = (struct pollfd *)vmalloc(size);
> } +
> }
> } vmalloc() & vfree() need lock_kernel(). Tigran wrote a patch, but that
> } patch is not (yet?) part of the standard kernel.
> }
> If you look carefully towards the top and bottom of sys_poll(), you'll
> see the {un}lock_kernel() calls.
>
Ups. I only read the patch without aplying it, sorry.
Ok, but then you should move the lock_kernel() calls as near as possible
to the actual do_poll() function call. This will improve the performance
on SMP. It's a complete waste to copy the data with the kernel locked.
sys_select() does that already.
-- Manfred- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat Jan 15 2000 - 21:00:18 EST