Re: [Patch] Cleanup struct gendisk registration, 2.3.40-pre1

From: Alexander Viro (aviro@redhat.com)
Date: Thu Jan 13 2000 - 16:24:36 EST


On Thu, 13 Jan 2000, Stephen C. Tweedie wrote:

> Hi,
>
> The patch below cleans up the struct gendisk handling in the block
> device layer for 2.3.40-1. It adds generic [un]register_gendisk
> functions, allows the gendisk to be registered automatically during
> register_blockdev(), and forces gendisk removal on
> unregister_blockdev().
>
> It also adds in a forgotten gendisk registration in the i2o stack.
>
> This code is a prerequisite for the "sard" advanced disk IO accounting
> patch, which accumulates disk stats in the gendisk arrays.
>
> --Stephen

Aaaargh. Resync time... Actually it's wrong way to handle that stuff -
correct one being per-disk instead of per-major. I'll have that done in a
couple of days.

Ob_gendisk(): Linus, why on the earth do we have this ->init() thing
there? It should be called from driver initialization code instead of the
middle of partition_setup(). Modules are calling it directly anyway,
conditions wrt interrupts are same, so what's the reason for postponing
the thing? IOW, will you accept moving the call to initialization and
removing gendisk.init?
                                                        Cheers,
                                                                Al

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Jan 15 2000 - 21:00:23 EST