Re: [Patch] Cleanup struct gendisk registration, 2.3.40-pre1

From: Andre Hedrick (andre@suse.com)
Date: Sat Jan 15 2000 - 03:05:53 EST


We are cruising now.....
I need 15 minutes to crash or fly........

On Sat, 15 Jan 2000, Alexander Viro wrote:

>
>
>
> On Fri, 14 Jan 2000, Andre Hedrick wrote:
>
> >
> > make[4]: Entering directory `/usr/local/src/linux-2.3.40-4/drivers/block'
> > gcc -D__KERNEL__ -I/linux/include -D__SMP__ -Wall -Wstrict-prototypes -O2
> > -fomit-frame-pointer -pipe -fno-strength-reduce -DCPU=686 -march=i686
> > -DEXPORT_SYMTAB -c ide.c
> > ide.c:553: warning: `struct ide_hwif_t' declared inside parameter list
> > ide.c:553: warning: its scope is only this definition or declaration,
> > ide.c:553: warning: which is probably not what you want.
> > ide.c: In function `ide_geninit':
> > ide.c:556: dereferencing pointer to incomplete type
> > ide.c:559: dereferencing pointer to incomplete type
> > ide.c: In function `get_info_ptr':
> > ide.c:1629: warning: unused variable `minor'
> > ide.c: In function `ide_init':
> > ide.c:3497: warning: passing arg 1 of `ide_geninit' from incompatible
> > pointer type
>
> Crrraaaap... Pre-compile patch disease. The only change between that and
> final was removing bogus 'struct' from "void ide_geninit(struct ide_hwif_t
> *hwif)". <diffing the patches> Yep.
> @@ -614,7 +614,7 @@
> + * ide_geninit() is called exactly *once* for each interface.
> */
> -void ide_geninit (struct gendisk *gd)
> -+void ide_geninit (struct ide_hwif_t *hwif)
> ++void ide_geninit (ide_hwif_t *hwif)
> {
> unsigned int unit;
> - ide_hwif_t *hwif = gd->real_devices;
>
> Ooops. Sorry about that, folks. I'm really need more coffee...
> Al
>

Andre Hedrick
The Linux IDE guy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Jan 15 2000 - 21:00:25 EST