Re: [Patch] Cleanup struct gendisk registration, 2.3.40-pre1

From: Andre Hedrick (andre@suse.com)
Date: Sat Jan 15 2000 - 02:43:21 EST


On Sat, 15 Jan 2000, Alexander Viro wrote:

> Hmm... you initialize drivers _after_ probing the interfaces. Check what
> it will do to the logics in ide_geninit(). Said that, reordering the stuff
> in ide_init() might be a better way. Comments?
>
> [snip]
>
> > Where are all the callbacks to "dev->init(dev)" located for block?
>
> They must die. They can't be called for modules, so you have to do the
> thing in module_init() anyway. Better move it to foo_init() and be done
> with that.

That explains a thing or two........if it works and there are no uglies,
it is a DGD (don't give a damn, not a concern) on how the higher levels of
the kernel handle their init() calldowns to the low-level sub-systems,
as long as the llss's are allowed whatever they need to get up and run.

Linus,

How does this proposal effect the cardbus issue from last night?
Fix, mild break, carpet bombing, ..............

This may be a straight forward to design expand upon the need for early
ISR handlers to be inserted and available to cardbus........

Of course this is all out of hat, but the thought has direction in mind
for the latter issue......

************ !DGD *************

make[4]: Entering directory `/usr/local/src/linux-2.3.40-4/drivers/block'
gcc -D__KERNEL__ -I/linux/include -D__SMP__ -Wall -Wstrict-prototypes -O2
-fomit-frame-pointer -pipe -fno-strength-reduce -DCPU=686 -march=i686
-DEXPORT_SYMTAB -c ide.c
ide.c:553: warning: `struct ide_hwif_t' declared inside parameter list
ide.c:553: warning: its scope is only this definition or declaration,
ide.c:553: warning: which is probably not what you want.
ide.c: In function `ide_geninit':
ide.c:556: dereferencing pointer to incomplete type
ide.c:559: dereferencing pointer to incomplete type
ide.c: In function `get_info_ptr':
ide.c:1629: warning: unused variable `minor'
ide.c: In function `ide_init':
ide.c:3497: warning: passing arg 1 of `ide_geninit' from incompatible
 pointer type
make[4]: *** [ide.o] Error 1
make[4]: Leaving directory `/usr/local/src/linux-2.3.40-4/drivers/block'
make[3]: *** [first_rule] Error 2
make[3]: Leaving directory `/usr/local/src/linux-2.3.40-4/drivers/block'
make[2]: *** [_subdir_block] Error 2
make[2]: Leaving directory `/usr/local/src/linux-2.3.40-4/drivers'
make[1]: *** [_dir_drivers] Error 2
make[1]: Leaving directory `/usr/local/src/linux-2.3.40-4'
make: *** [drivers] Error 2

A Mess........will try to clean up........and make a go at it......

Andre Hedrick
The Linux IDE guy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Jan 15 2000 - 21:00:26 EST