Re: [Patch] Cleanup struct gendisk registration, 2.3.40-pre1

From: Alexander Viro (aviro@redhat.com)
Date: Sat Jan 15 2000 - 19:45:03 EST


On Sun, 16 Jan 2000, Alan Cox wrote:

> > Linus, is there any reason to have separate blk_dev_init()? Many
> > things (e.g. SCSI) are done outside of it (later). What about gutting it
> > completely and doing analog of initcalls instead? I realize that there are
> > issues with ordering, but how bad they are?
>
> I'd much rather this redoing of stuff didnt expand further. The job list
> is growing not shrinking right now. Its making me jumpy at least.

Reasonable. However, there is an impressive collection of bug-reports on
interaction between ide-scsi and other ide drivers giving exactly the same
mess that Andre got with this patch and I really wonder if this is due to
bad ordering of ide and scsi initializations. I'm less than happy about
the look of ide_init() - look at it yourself and check the usage of
'initialized' in drivers/block/ide.c ;-/ It seems that we are kludging
around some dependency problems here. I would really appreciate if
somebody familiar with upper layers of ide subsystem and with ide-scsi
would comment on situation.
                                                        Cheers,
                                                                Al

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Jan 23 2000 - 21:00:13 EST