Re: Scheduler & semaphore patch for 2.2.14 ...

From: Pavel Machek (pavel@suse.cz)
Date: Mon Jan 24 2000 - 06:43:15 EST


Hi!

> > there's no chance for this to go into 2.2.X (not a bugfix). 2.3.X is
> > better target.
>
> There is another issues coz the patch has a bug that came out in SMP.
> Line 924 in sched.c must be changed from :
>
> if ((c <= 0) && (nr_running > 0))
>
> to :
>
> #ifdef __SMP__
> if ((c <= 0) && (nr_running >= smp_num_cpus)) /* To fix better */
> #else
> if ((c <= 0) && (nr_running > 0))
> #endif /* __SMP__ */

Why not

if ((c <= 0) && (nr_running >= smp_num_cpus)) /* To fix better */

and define smp_num_cpus to 1 if case of UP system? [I think it already
_is_ defnied like this...]
                                                                Pavel

-- 
The best software in life is free (not shareware)!		Pavel
GCM d? s-: !g p?:+ au- a--@ w+ v- C++@ UL+++ L++ N++ E++ W--- M- Y- R+

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Jan 31 2000 - 21:00:11 EST