Re: [linux-usb] __initcall diff, version 2

From: Pavel Machek (pavel@suse.cz)
Date: Tue Feb 01 2000 - 06:30:16 EST


Hi!

> > I like the idea of this __initcall patch for USB.
> > However, I've searched other 2.3.4x drivers and found
> > very little use of __initcall.
>
> It's fairly new. I heartily encourage initcalls, they are _much_ nicer
> than explicit initialization. The explicit way only makes sense for (a)
> old drivers and (b) code that requires certain ordering.
>
> However, instead of using "__initcall" directly, I would suggest using
> "module_init()" and "module_exit()". Which will do the right things
> for

Notice that I'm going to do that, but that diff will be slightly
bigger. I wanted to have simple thing working first. Currently, I add
single line to each driver, module_init() will require me to rename
functions and kill ugly #ifdef MODULE.

                                                                Pavel

-- 
The best software in life is free (not shareware)!		Pavel
GCM d? s-: !g p?:+ au- a--@ w+ v- C++@ UL+++ L++ N++ E++ W--- M- Y- R+

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Feb 07 2000 - 21:00:06 EST