Re: cardbus problem (with oops)

From: Danilo Beuche (danilo@oscar.cs.uni-magdeburg.de)
Date: Tue Feb 01 2000 - 08:15:49 EST


Hi,

I had the same problems that ejecting a cardbus card locked up my notebook.
I traced it down to pci_remove_device(), which does

        if (dev->driver->remove)
        {
                ...
        }

The check itself causes the oops because for my cardbus device (3c575)
dev->driver is NULL. The only driver which works okay is the tulip_cb
which does a pci_register_device instead of register_device (all other
cardbus cards call this).

The quick fix would be
        if (dev->driver && dev->driver->remove)
        {
        ...
        }

which makes it more robust against misuse. But I guess the prefered way
is to fix the cardbus drivers to register the devices as pci devices correctly.

Danilo

-- 
Danilo Beuche				Phone: +49-391-67-11459
Universität Magdeburg			Fax:   +49-391-67-12810	
Computer Science Department		Raum   D207a
					EMail: danilo@ivs.cs.uni-magdeburg.de


- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Feb 07 2000 - 21:00:06 EST