Re: parport_pc

From: Tim Waugh (twaugh@redhat.com)
Date: Fri Feb 04 2000 - 04:30:48 EST


On Fri, 4 Feb 2000, Richard Zidlicky wrote:

> This doesn't solve the problem with missing pci_alloc_consistent(),

Ah, that's a bug then.

Index: linux/drivers/parport/parport_pc.c
diff -u linux/drivers/parport/parport_pc.c:1.23 linux/drivers/parport/parport_pc.c:1.24
--- linux/drivers/parport/parport_pc.c:1.23 Tue Feb 1 10:44:17 2000
+++ linux/drivers/parport/parport_pc.c Fri Feb 4 09:24:57 2000
@@ -1667,6 +1667,7 @@
                         p->dma = PARPORT_DMA_NONE;
                 }
 
+#ifdef CONFIG_PARPORT_PC_FIFO
                 if (p->dma != PARPORT_DMA_NONE) {
                         if (request_dma (p->dma, p->name)) {
                                 printk (KERN_WARNING "%s: dma %d in use, "
@@ -1688,6 +1689,7 @@
                                 }
                         }
                 }
+#endif /* CONFIG_PARPORT_PC_FIFO */
         }
 
         /* Done probing. Now put the port into a sensible start-up state.

> furthermore I *have* FIFO (ECP) so I would hate to disable it just to
> workaround for missing DMA.

Well, yes, fiddling with config options was always going to be a
work-around -- I thought your original mail said that you were after a
short-term fix as well. Making pci_alloc_consistent work properly is
obviously the solution we all want.

Tim.
*/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Feb 07 2000 - 21:00:10 EST