Re: [PATCH] fs/select.c cleanups.

• Next message: Barrie Spence: "command line args trucation? (ok 2.2.10, broken 2.2.13)"
• Previous message: Manfred Spraul: "Re: 2.3.42 alpha updates"
• In reply to: Bill Wendling: "[PATCH] fs/select.c cleanups."
• Next in thread: Bill Wendling: "Re: [PATCH] fs/select.c cleanups."
• Reply: Bill Wendling: "Re: [PATCH] fs/select.c cleanups."
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Bill Wendling wrote:
>
> Here's a patch to clean up some things in the fs/select.c file. The first
> is to reduce the number of times the do_pollfd() function is called by
> moving the loop into the function. There was also a way to move kernel
> locking closer to the code it needed to be near in the select()
> functions.
>

Could you please wait with this patch? It's unclear if it's allowed or
illegal to call __get_free_page() while "current->state !=
TASK_RUNNING". __pollwait() does exactly that.

I've written a similar patch, but I'll wait until the allocation problem
has settled down (the "2.2.15pre5: still very unstable" thread).

And _pollwait() ignores oom. Hmm. I think my patch is required. I'll
merge your changes and forward the result to Linus. Ok?

--
	Manfred
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Barrie Spence: "command line args trucation? (ok 2.2.10, broken 2.2.13)"
• Previous message: Manfred Spraul: "Re: 2.3.42 alpha updates"
• In reply to: Bill Wendling: "[PATCH] fs/select.c cleanups."
• Next in thread: Bill Wendling: "Re: [PATCH] fs/select.c cleanups."
• Reply: Bill Wendling: "Re: [PATCH] fs/select.c cleanups."
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Mon Feb 07 2000 - 21:00:11 EST