Re: Softnet/eepro100 driver conversion bug in 2.3.43pre8?

From: Manfred Spraul (manfreds@colorfullife.com)
Date: Sun Feb 13 2000 - 15:09:10 EST


Jeff Garzik wrote:
>
> Some bug reports to linux-kernel, and my own experience testing 8139too,
> seem to say otherwise...
>
> I got _constant_ timeouts on UP until I updated the 8139too interrupt
> handler from
>
> if (tx buffer not full) {
> tx_full=0;
> netif_wake_queue(dev);
> }
>
> to
>
> if (tx buffer not full) {
> tx_full = 0;
> }
> if (tx_full)
> netif_wake_queue(dev);
> else
> netif_stop_queue(dev);
>
I assume you twisted the netif_xy_queue() calls:
if(tx_full)
        stop();
 else
        wake();

Did you check why? Was the tx ring full, but the queue not stopped, or
something like this? Perhaps the timeout function is called to early?

--
	Manfred

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Feb 15 2000 - 21:00:25 EST