Tim Waugh writes:
> Here's a patch that moves the devfs_register call from lp_init to
> lp_register. The point is that it's quite valid for lp to load before any
> parallel port drivers.
OK, thanks. One nit:
> @@ -690,6 +692,12 @@
> if (reset)
> lp_reset(nr);
>
> + sprintf (name, "%d", nr);
> + devfs_register (devfs_handle, name, 0,
> + DEVFS_FL_DEFAULT, LP_MAJOR, i,
> + S_IFCHR | S_IRUGO | S_IWUGO, 0, 0,
> + &lp_fops, NULL);
> +
You forgot to change the second 'i' to "nr".
NOTE: please send all devfs-related bugs directly to me and not the
list so I can collate them and send patches to Linus. Otherwise my
patches will start breaking.
Regards,
Richard....
Permanent: rgooch@atnf.csiro.au
Current: rgooch@ras.ucalgary.ca
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Wed Feb 23 2000 - 21:00:20 EST