2.3.47 tulip.c race?

From: Harley Privitera (jhp@pobox.com)
Date: Tue Feb 22 2000 - 10:30:28 EST


I had to apply the following patch to get tulip.c to function as a
module; without it, I'd see a BUG @spinlock.h:78

I've also included a hunk that fixes a typo

/harley

*** tulip.c-2.3.47 Mon Feb 21 09:03:03 2000
--- tulip.c Mon Feb 21 14:00:29 2000
***************
*** 945,951 ****
          /* now it is safe to change csr6 */
          outl (newcsr6, ioaddr + CSR6);
  
! spin_unlock_irqrestore (&tp->lock, flags);
  }
  
  
--- 945,951 ----
          /* now it is safe to change csr6 */
          outl (newcsr6, ioaddr + CSR6);
  
! spin_unlock_irqrestore (&tp->tx_lock, flags);
  }
  
  
***************
*** 2804,2809 ****
--- 2804,2810 ----
  
          tp = dev->priv;
          memset(tp, 0, sizeof(*tp));
+ spin_lock_init(&tp->tx_lock);
  
          pci_read_config_byte (pdev, PCI_REVISION_ID, &chip_rev);
  
***************
*** 2932,2938 ****
  #ifdef TULIP_NO_MEDIA_SWITCH
          tp->medialock = 1;
  #endif
! tp->tx_lock = SPIN_LOCK_UNLOCKED;
  
          /* The lower four bits are the media type. */
          if (board_idx >= 0 && board_idx < MAX_UNITS) {
--- 2933,2939 ----
  #ifdef TULIP_NO_MEDIA_SWITCH
          tp->medialock = 1;
  #endif
! // tp->tx_lock = SPIN_LOCK_UNLOCKED;
  
          /* The lower four bits are the media type. */
          if (board_idx >= 0 && board_idx < MAX_UNITS) {

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Feb 23 2000 - 21:00:30 EST