Re: drivers/parport/parport_pc.c

• Next message: Horst von Brand: "Re: Improper headers"
• Previous message: Christoph Hellwig: "[PATCH] Yet another sound/oss cleanup"
• In reply to: Russell King: "drivers/parport/parport_pc.c"
• Next in thread: Pete Clements: "Re: drivers/parport/parport_pc.c"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Russell King wrote:
>
> Hi,
>
> The following patch allows parport_pc.c to be compiled on architectures
> without PCI support.

That was my parport patch, thanks for the fix.

This bring up something I was thinking about the other day: I am kinda
disappointed that the choice was made to ditch the !CONFIG_PCI code from
pci.h. There used to be a ton of inlined helpers which replaced all the
PCI functions with no-ops, preventing problems like this parport
breakage.

Maybe I am one of the few who doesn't mind bloating driver code a tiny
bit in order to handle the !CONFIG_PCI case without ugly ifdefs in
driver code...

-- 
Jeff Garzik              | "Are you the police?"
Building 1024            | 
MandrakeSoft, Inc.       | "No ma'am.  We're musicians."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Horst von Brand: "Re: Improper headers"
• Previous message: Christoph Hellwig: "[PATCH] Yet another sound/oss cleanup"
• In reply to: Russell King: "drivers/parport/parport_pc.c"
• Next in thread: Pete Clements: "Re: drivers/parport/parport_pc.c"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Tue Feb 29 2000 - 21:00:17 EST