RE: [linux-fbdev] [PATCH] matrxofb i2c fix

From: Brad Douglas (Brad@NERUO.com)
Date: Sun Feb 27 2000 - 18:13:39 EST


> -----Original Message-----
> From: Jeff Garzik [mailto:jgarzik@mandrakesoft.com]
> >
> > With the latest kernel you can have the matrox driver
> compiled with i2c
> > support without having i2c support in the kernel. This
> causes the compile
> > to fail. This patch fixes this. It test to see if you have
> i2c support
> > selected.
>
> IMHO I2C is such a low-level bus, the user might not know to select it
> until it is too late.
>
> Why not instead have
>
> define_tristate CONFIG_I2C $CONFIG_FB_MATROX

v4l is the same way. If you forget to choose the right i2c (or don't choose
bit-banging), then it crashes on compile. Well, at least last time I
compile in v4l this happened...

The above looks good.

Brad Douglas
brad@neruo.com
http://www.linux-fbdev.org

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Feb 29 2000 - 21:00:18 EST