Re: Unnecessary zero initializers (was Re: [PATCH 2.3.48] initrd fix (Mike Galbraith))

From: Bradley D. LaRonde (brad@ltc.com)
Date: Sun Feb 27 2000 - 23:41:18 EST


----- Original Message -----
From: "Bradley D. LaRonde" <brad@ltc.com>
To: "Russell King" <rmk@arm.linux.org.uk>; "Alan Cox"
<alan@lxorguk.ukuu.org.uk>
Cc: "Frank Bernard" <fb@fbit.de>; <torvalds@transmeta.com>; "Linux Kernel"
<linux-kernel@vger.rutgers.edu>
Sent: Sunday, February 27, 2000 8:07 PM
Subject: Unnecessary zero initializers (was Re: [PATCH 2.3.48] initrd fix
(Mike Galbraith))

> ----- Original Message -----
> From: "Russell King" <rmk@arm.linux.org.uk>
> To: "Alan Cox" <alan@lxorguk.ukuu.org.uk>
> Cc: "Frank Bernard" <fb@fbit.de>; <torvalds@transmeta.com>; "Linux Kernel"
> <linux-kernel@vger.rutgers.edu>
> Sent: Sunday, February 27, 2000 12:09 PM
> Subject: Re: [PATCH 2.3.48] initrd fix (Mike Galbraith)
>
>
> > Alan Cox writes:
> > > > Is there any reason (apart from making vmlinux and kernel binary
> images larger)
> > > > for explicitly initialising variables with 0 when they will be
placed
> in the
> > > > BSS anyway?
> > >
> > > Long long ago (before 1.0) the kernel didnt zero the BSS. Some legacy
of
> > > that survives in old assignments - otherwise none
> >
> > Oh, I remember those kernels ;)
> >
> > However, I noticed that the patch was introducing some extra explicit
zero
> > initialisations.
>
> There are some big ones in drivers/block/ll_rw_blk.c. I submitted a patch
a
> while back to get them removed, but it looks like they are still there in
> 2.3.48.

Whoops, looks like they were removed in 2.3.43. Cool.

Regards,
Brad

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Feb 29 2000 - 21:00:19 EST