Re: [PATCH] Debugging messages compacting

From: Jeff Garzik (jgarzik@mandrakesoft.com)
Date: Mon Feb 28 2000 - 15:47:30 EST


Ingo Molnar wrote:
>
> On Mon, 28 Feb 2000, Andrey Panin wrote:
>
> > this small and self explaining patch, reduce kernel image
> > size (uncompressed) by several kiloBytes.
> >
> > It replaces some debugging messages spread around kernel image
> > ("wq bug, forcing oops", "kernel bug at %s" etc.) with
> > 4 string placed in messages.c file.
>
> DEBUG_WAITQUEUE will be turned off (and the code complication will be
> removed) in 2.4. Some of the BUG()s will be / should be removed as well,
> but sharing the 'BUG' printk message makes sense otherwise. Wouldnt it be
> better to put that single string definition into kernel/printk.c instead
> of a completely new file?

If we are putting messages into a file, please do it in such a way that
internationalization teams can easily replace the messages with
localized ones...

-- 
Jeff Garzik              | "Are you the police?"
Building 1024            | 
MandrakeSoft, Inc.       | "No ma'am.  We're musicians."

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Feb 29 2000 - 21:00:20 EST