Re: [PATCH] make checkstruct (was Re: [PATCH] file_operations policing and CodingStyle addition)

From: James Manning (jmm@computer.org)
Date: Mon Feb 28 2000 - 23:41:57 EST


[ Monday, February 28, 2000 ] Jeff Garzik wrote:
> Very cool, though I'm wondering if it wouldn't be more useful to have a
> list of check-able struct types... I am sure that not all struct
> initializations need to be gcc-ified.

A simple enough change .. attached :) Only a few from linux/fs.h
currently selected, just to increase the chances of Linus accepting it.

jmm@ns1:/usr/src/linux-check> make checkstruct
find * -name '*.[hc]' -type f -print | xargs perl -w scripts/checkstruct.pl
arch/mips64/sgi-ip27/ip27-rtc.c: non-gcc struct file_operations init
drivers/char/ds1620.c: non-gcc struct file_operations init
drivers/char/nwbutton.c: non-gcc struct file_operations init
drivers/char/nwflash.c: non-gcc struct file_operations init
drivers/char/wdt285.c: non-gcc struct file_operations init
drivers/char/wdt977.c: non-gcc struct file_operations init
drivers/isdn/avmb1/capi.c: non-gcc struct file_operations init
drivers/isdn/divert/divert_procfs.c: non-gcc struct file_operations init
drivers/isdn/hysdn/hysdn_procconf.c: non-gcc struct file_operations init
drivers/isdn/hysdn/hysdn_procfs.c: non-gcc struct file_operations init
drivers/isdn/hysdn/hysdn_proclog.c: non-gcc struct file_operations init
drivers/isdn/isdn_common.c: non-gcc struct file_operations init
drivers/macintosh/via-pmu68k.c: non-gcc struct file_operations init
drivers/usb/scanner.c: non-gcc struct file_operations init
fs/dquot.c: non-gcc struct dquot_operations init

(note the last one is for dquot_operations. I've already sent Linus
 a patch for all the above file_operations init's, of course, since that
 started this thread :)

James



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Feb 29 2000 - 21:00:21 EST