>>>>> "Jeff" == Jeff Garzik <jgarzik@mandrakesoft.com> writes:
Jeff> Urg.... This is precisely what we are trying to move __away__
Jeff> from in 2.3.x.
Jeff> The code at the top should look like
Jeff> #if old_kernel_version #define netif_running(dev) ... #endif
Jeff> You should not be wrapping standard kernel functions as it only
Jeff> serves to obscure the code.
Jeff, there is nothing wrong with that patch. If you want to go on a
crusade cleaning up this sort of stuff, then there are plent of other
drivers where the entire driver has redefined everything. Yes it would
be slightly cleaner to do it as say, but it's not exactly a big deal.
Jes
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue Mar 07 2000 - 21:00:16 EST