Re: Irq context wrong for USB ACM serial driver calling PPP?

From: kuznet@ms2.inr.ac.ru
Date: Mon Mar 06 2000 - 15:22:29 EST


Hello!

> Well, the USB ACM driver does just tty_flip_buffer_push() from an
> interrupt, which I think is normal even for other drivers? Well, if not,
> I can change it ...
>
> Hmm, it also calls a tty->ldisc.write_wakeup from an interrupt. Might
> this be the cause?

It is interesting. Why does it not overrun in this case?
Common serial card will surely overrun, when pushing data block
from its own irq.

Yes, this work should be done from bh. And if internal card buffer
is less than flip buffer, it must be done from bh.

Alexey

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Mar 07 2000 - 21:00:20 EST