Re: 2.3.4[89] fail to probe/id IDE properly (long)

From: Tim Coleman (tim@beastor.mine.nu)
Date: Tue Mar 07 2000 - 16:49:51 EST


On Tue, Mar 07, 2000 at 03:21:52PM -0500, Jeff Garzik wrote:
> [snipping]
>
> Look at Tim Coleman's latest patch. It appears to address mentioned
> issues, and looks good to me for the 4-5 drivers I manually checked
> against his patch.
>

Before you use it, you might want to change this:

---> if [ "$CONFIG_PCI" = "y" ]; then
         if [ "$CONFIG_EXPERIMENTAL" = "y" ]; then
            tristate ' DM9102 PCI Fast Ethernet Adapter support (EXPERIMENTAL)' CONFIG_DM9102
         fi
      fi

I missed the closing " on "$CONFIG_PCI" in the
patch. I couldn't figure out why it wouldn't
work -- I should have turned on syntax highlighting.

> (as I mentioned in private mail to Andre) Note that pci.h needs to be
> fixed in 2.3.current so that it correctly and fully handles the
> !CONFIG_PCI case. Ideally pci.h should define inline no-op functions
> when !CONFIG_PCI, so that drivers need not test CONFIG_PCI at all
> themselves.

That would be really nice and would fix things like the problem I had on
2.3.48 with CONFIG_PCI breaking parport code (?!) I have yet to try
anything later.

Tim

-- 
------------------------------------------------------------------------
tim@beastor.mine.nu
Software Developer/Systems Administrator/RDBMS Specialist/Linux Advocate
University of Waterloo Honours Co-op Combinatorics & Optimization
finger tim@beastor.mine.nu for PGP public key ID 0xCB7C7974


- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Mar 07 2000 - 21:00:23 EST