Re: Call for 2.3.x Appletalk testers...

From: David S. Miller (davem@redhat.com)
Date: Mon Mar 13 2000 - 20:42:43 EST


   Date: Mon, 13 Mar 2000 15:03:32 +0100
   From: Thomas Sailer <sailer@ife.ee.ethz.ch>

   With the appletalk code in 2.3.51, I can no longer use
   netatalk. Both getzones and papstatus try to bind to
   apparently the all zero address and get EADDRINUSE

Well, I did give people nearly a month to find bugs like
this when I made a call for testers way back then. Good
thing I just put it in, because this aparently made people
unlazy enough to test the changes and report problems :-)

This patch should fix the EADDRINUSE problem:

--- net/appletalk/ddp.c.~1~ Tue Feb 15 09:25:55 2000
+++ net/appletalk/ddp.c Mon Mar 13 17:41:15 2000
@@ -1378,11 +1378,12 @@
 
                 if (n < 0)
                         return n;
- } else
+ } else {
                 sk->protinfo.af_at.src_port = addr->sat_port;
 
- if (atalk_find_or_insert_socket(sk, addr) != NULL)
- return -EADDRINUSE;
+ if (atalk_find_or_insert_socket(sk, addr) != NULL)
+ return -EADDRINUSE;
+ }
 
         sk->zapped = 0;
 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Mar 15 2000 - 21:00:26 EST