Re: [bugfix] SMP, shm-2.3.52-A0

From: Andrew Morton (morton@nortelnetworks.com)
Date: Fri Mar 17 2000 - 19:41:56 EST


Ingo Molnar wrote:
>
> > + KASSERT(spin_is_locked(&kernel_flag));
>
> this is more readable i believe:
>
> if (!spin_is_locked(&kernel_flag))
> BUG();

Yes. But your assertion needs to be physically removed from production
code, whereas the presence/absence of KASSERT can be centrally
controlled.

        if (assertions && !spin_is_locked(&kernel_flag))
                BUG();

will compile to nothing if 'assertions' is constant zero.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Mar 23 2000 - 21:00:22 EST