Re: [bugfix] SMP, shm-2.3.52-A0

From: Manfred Spraul (manfreds@colorfullife.com)
Date: Fri Mar 17 2000 - 10:07:22 EST


From: "Andrew Morton" <morton@nortelnetworks.com>
>
> Prevent this from ever happening again....
I would love to see a kassert() macro in the kernel, but

> +
> + KASSERT(spin_is_locked(&kernel_flag));
>
Did you actually test your patch?

from linux/include/linux/spinlock.h:
#ifndef __SMP__
    #define spin_is_locked(lock) 0
#endif

you cannot use spin_is_locked() in your assert macro, you need a special
"kassert_locked()" macro :-(

--
    Manfred

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Mar 23 2000 - 21:00:22 EST