Re: [2.2.15-pre15] compile (link) error

From: Christian Ehrhardt (ehrhardt@mathematik.uni-ulm.de)
Date: Mon Mar 20 2000 - 08:14:43 EST


On Sat, Mar 18, 2000 at 09:16:14PM +0100, Arjan van de Ven wrote:
> > Yes but:
>
> > /usr/src/linux-2.2.15p15/kernel
> > # fgrep in_egroup_p *.c
> > sysctl.c:static int in_egroup_p(gid_t grp)
> > ^^^^^^
>
>
> Not only is it static, it should NOT be in sysctl.c, but in sys.c instead.

Shouldn't we use fsuid and in_group_p for the check in dquot.c?

> (The same bug was in 2.3 for a while but this is fixed now). There is
> nothing in in_egroup_p that has anything to do with sysctl, and the
> dependency on CONFIG_SYSCTL bogus.

in_egroup_p is special in that it performs permission checks on file
system like objects using egid and not fsgid. We normally shoudn't
need something like this.

   regards Christian

-- 
****************************************************************************
** Christian Ehrhardt  **  e-Mail: ehrhardt@mathematik.uni-ulm.de  *********
****************************************************************************
THAT'S ALL FOLKS!

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Mar 23 2000 - 21:00:29 EST