Re: [patch] repost of netfilter/NIPQUAD patches

From: Linus Torvalds (torvalds@transmeta.com)
Date: Fri Apr 14 2000 - 14:39:01 EST


In article <E12gBD9-0004F4-00@g212.hadiko.de>,
Olaf Titz <olaf@bigred.inka.de> wrote:
>> How about changing printk() so it knows how to output ipv4 dotted quads?
>
>Either that, or make a kernel version of inet_ntoa().
>I'm already using the latter approach in CIPE:

Don't people ever learn?

We used to have inet_ntoa(). We got rid of the horrible crap, because it
is neither thread-safe nor even able to be used multiple times for
printk except with ugly hacks like yours.

What's the advantage of using %s + inet_ntoa() when compared to using
the very straightforward %u.%u.%u.%u + NIP_QUAD()? There is none.

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Apr 15 2000 - 21:00:25 EST