Re: kiobuf question

From: Stephen C. Tweedie (sct@redhat.com)
Date: Mon Apr 17 2000 - 10:28:13 EST


Hi,

On Mon, Apr 17, 2000 at 02:32:20PM +0200, Manfred Spraul wrote:
 
> static void end_buffer_io_kiobuf(struct buffer_head *bh, int uptodate)
> {
> struct kiobuf *kiobuf;
> kiobuf = bh->b_kiobuf;
...
> kiobuf = bh->b_kiobuf;
> }
>
> Why is b_kiobuf read twice?

Pilot error I expect. :) Thanks for spotting it.

> And I don't understand why we have b_kiobuf at all: AFAICS the kiobuf
> functions could use b_dev_id.

I wondered about that, but there's a problem if any device drivers
want to use that field themselves. In particular, if lvm or soft
raid decides to start using that field in buffer_heads passed into
those drivers, we're in trouble.

--Stephen

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Apr 23 2000 - 21:00:11 EST