Re: [patch] repost of netfilter/NIPQUAD patches

From: Florian Weimer (fw@deneb.cygnus.argh.org)
Date: Mon Apr 17 2000 - 15:00:09 EST


olaf@bigred.inka.de (Olaf Titz) writes:

> > All network address strings have a bounded length, therefore you can
> > allocate a string buffer for each address on the stack in the caller,
> > and have the inet_ntoa()-like functions fill it. This buffer can be
> > passed to printk() with an ordinary "%s" flag.
>
> Still too much code duplication (and it reeks of the SMALLBUF, BIGBUF
> things found in too many apps).

No, just one type, "netaddrstring_t" or something like that, for
exactly this purpose.

> This is _perfect_ stuff for writing a suitable library function.

What is a suitable library function in this case, IYO?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Apr 23 2000 - 21:00:11 EST