Re: register_pccard_driver vs register_pcmcia_driver...

From: Andrew Morton (andrewm@uow.edu.au)
Date: Mon Apr 17 2000 - 22:40:40 EST


Adam Fritzler wrote:
>
> Seems everything in drivers/net/pcmcia uses register_pccard_driver(),
> except for aironet4500_cs and ray_cs (I'm interested in the latter).
> I assume register_pccard_driver is the modern (and preferred) call.
> Should I send a patch to change them?

Given that we have:

#define register_pcmcia_driver register_pccard_driver
#define unregister_pcmcia_driver unregister_pccard_driver

I asume you're right - *_pccard_* is the one to use. I foggily believe
that 'pcmcia' is the name of the industry consortium and 'CardBus' and
'PC-Card' are the names of the technolgies which PCMCIA defines.

> Also, is CardServices() preferred, or is it okay to call the individual
> functions?
>
> I'm really trying to figure out way ray_cs sends a long stream of Oops' on
> rmmod in newish 2.3.99. Its getting quite annoying.

hmmm... 3c575_cb.c reliably oopses on removal. This is because it is
not calling pci_unregister_driver() on module removal. The fix is to
replace

    if (rc > 0)
        vortex_have_pci = 1;

with

    if (rc >= 0)
        vortex_have_pci = 1;

in vortex_init(). No fix proposed for this because 3c575_cb is
hopefully to be folded into 3x59x.c RSN.

But this is totally irrelevant to your problem because the card services
stuff seems to be a completely separate driver management and
registration layer.

What's the long-term plan here? Is the PCMCIA card services layer now
obsolete?

-- 
-akpm-

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Apr 23 2000 - 21:00:12 EST