Re: [PATCH] f_op->poll() without lock_kernel()

From: Alexander Viro (viro@math.psu.edu)
Date: Fri Apr 21 2000 - 21:23:26 EST


On Fri, 21 Apr 2000, David S. Miller wrote:

> Date: Fri, 21 Apr 2000 20:28:53 -0400 (EDT)
> From: Alexander Viro <viro@math.psu.edu>
>
> On Fri, 21 Apr 2000, David S. Miller wrote:
>
> > I highly approve of this, please just do it.
>
> Dave, what's up with sock_no_foo() stuff? Mind if I'll replace (some
> of?) them with NULLs, taking the tests into net/socket.c?
>
> Please no, the whole point of the sock_no_*() stuff was to _REMOVE_
> the tests from the socket.c code.

OK, what about the following:

        a) ->fcntl() is _always_ sock_no_fcntl().
        b) ->socketpair() is nontrivial only for AF_UNIX.
        c) ->mmap() is nontrivial only for AF_PACKET and I'm not too happy
about its abuse there.

[patch being tested right now; the question being whether we want to keep
->fcntl() or not]

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Apr 23 2000 - 21:00:20 EST