Re: [PATCH] f_op->poll() without lock_kernel()

From: Alexander Viro (viro@math.psu.edu)
Date: Sat Apr 22 2000 - 20:15:20 EST


On Sat, 22 Apr 2000 kuznet@ms2.inr.ac.ru wrote:

> Hello!
>
> > OK, what about the following:
> >
> > a) ->fcntl() is _always_ sock_no_fcntl().
>
> The question is strange. Does fcntl() hurt you? Who did tell you that
> it is not used by some propriate modules? Or fcntl() is prohibited
> for export? Why then is it present in fops? If method already exists,
> there are no reasons to delete it.
>
> [ "Lomat -- ne stroit". Do you understand? 8) ]
>
> It would be better, if you audited things which are _not_ passed
> to socket layer by mistake and added methods for them.

Sorry, but that's completely insane. file_operations did change in past
and will change in future. If something is not needed by 3rd-party code -
fine, less pain if we'll have to change it. "Export everything just in
case" is bloody bad default.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Apr 23 2000 - 21:00:21 EST