Re: chroot_fs_refs() question

From: Alexander Viro (aviro@redhat.com)
Date: Thu Apr 27 2000 - 08:28:41 EST


On Thu, 27 Apr 2000, Tigran Aivazian wrote:

> Hi Al,
>
> I see in fs/super.c:chroot_fs_refs() that you surrounded the code which is
> protected by tasklist_lock spinlock with dget/dput of old_root (and
> corresponding mntget/mntput though they are harmless at present) to avoid
> dput(old_root) blocking inside set_fs_root().
>
> But doesn't the same applies to dput(old_pwd) which can still block in
> each individual set_fs_pwd()? Or, there must be some trick you've done
> that I am missing from looking at the source - hence this email..

Erm.. _What_ old_pwd? Check the code - especially the comparison before
set_fs_pwd() call...

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Apr 30 2000 - 21:00:12 EST