"typo" in coda_linux.h

From: Rogier Wolff (R.E.Wolff@BitWizard.nl)
Date: Sat Apr 29 2000 - 07:04:15 EST


Hi,

In macros the "do { ... } while (0)" trick is often used, because
otherwise something could go wrong if the macro is called from inside
an if statement.

All this is defeated if you append a ";" to the macro
definition. Right?

                                Roger.

diff -ur linux-2.3.99-pre3.rewclean/include/linux/coda_linux.h linux/include/linux/coda_linux.h
--- linux-2.3.99-pre3.rewclean/include/linux/coda_linux.h Sun Feb 27 05:33:43 2000
+++ linux/include/linux/coda_linux.h Sat Apr 29 13:51:03 2000
@@ -102,7 +102,7 @@
   if (coda_debug & mask) { \
     printk("(%s,l. %d): ", __FUNCTION__, __LINE__); \
     printk(format, ## a); } \
-} while (0) ;
+} while (0)
 
 #define ENTRY \
     if(coda_print_entry) printk("Process %d entered %s\n",current->pid,__FUNCTION__)

-- 
** R.E.Wolff@BitWizard.nl ** http://www.BitWizard.nl/ ** +31-15-2137555 **
*-- BitWizard writes Linux device drivers for any device you may have! --*
*       Common sense is the collection of                                *
******  prejudices acquired by age eighteen.   -- Albert Einstein ********

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Apr 30 2000 - 21:00:16 EST