Re: [PATCH] rtc.c fix

From: Cesar Eduardo Barros (cesarb@web4u.com.br)
Date: Sat Apr 29 2000 - 13:25:59 EST


On Sat, Apr 29, 2000 at 08:14:46PM +0200, Richard Torkar wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Sat, 29 Apr 2000, Cesar Eduardo Barros wrote:
>
> > On Sat, Apr 29, 2000 at 02:14:47PM +0200, Richard Torkar wrote:
> > > The patch you provided has been running on a 2.3.99-pre6 dual 500
> > > Celeron system for 24 hours under heavy load so far... :)
> > >
> >
> > <looks surprised> Wow, it works! =)
> >
> > Well, that's not enough yet. It needs to be tested with some program which uses
> > /dev/rtc (like the one in Documentation/rtc.txt). I will probably do it
> > tomorrow.
> >
> > At least now I know it won't crash on boot =)
>
> I tried rtctest as root here is the output. (looks normal to me :)
> ****
>
> [root@/tmp]# ./rtctest
>
> RTC Driver Test Example.
>
> Counting 5 update (1/sec) interrupts from reading /dev/rtc: 1 2 3 4 5
> Again, from using select(2) on /dev/rtc: 1 2 3 4 5
>
> Current RTC date/time is 29-4-2000, 20:09:22.
> Alarm time now set to 20:09:27.
> Waiting 5 seconds for alarm... okay. Alarm rang.
>
> Periodic IRQ rate was 64Hz.
> Counting 20 interrupts at:
> 2Hz: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20
> 4Hz: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20
> 8Hz: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20
> 16Hz: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20
> 32Hz: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20
> 64Hz: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20
>
> *** Test complete ***
>
> Typing "cat /proc/interrupts" will show 131 more events on IRQ 8.
>
> Here is cat /proc/interrupts
> [root@/tmp]# cat /proc/interrupts
> CPU0 CPU1
> 0: 3898174 3986084 IO-APIC-edge timer
> 1: 28073 28271 IO-APIC-edge keyboard
> 2: 0 0 XT-PIC cascade
> 5: 2044763 2068073 IO-APIC-edge eth0
> 7: 1400 1372 IO-APIC-edge soundblaster
> 8: 135 128 IO-APIC-edge rtc
> 12: 128042 131504 IO-APIC-edge PS/2 Mouse
> 13: 1 0 XT-PIC fpu
> 14: 382 375 IO-APIC-edge ide0
> 15: 6 0 IO-APIC-edge ide1
> 18: 341815 340269 IO-APIC-level ide2
> NMI: 7884175 7884175
> LOC: 7883605 7883604
> ERR: 8041
>

It seems OK for me too (though showing /proc/rtc only after the test has been
done adds nothing at all). I'll forward the patch to Linus now then (if it
worked on SMP, no way in hell it's gonna break on my UPs unless my slow 386 can
force the issue more than a faster box).

Thanks for the help.

-- 
Cesar Eduardo Barros
cesarb@web4u.com.br
cesarb@dcc.ufrj.br

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Apr 30 2000 - 21:00:17 EST