Re: [patch] 3c59x.c

From: Andrew Morton (andrewm@uow.edu.au)
Date: Tue May 02 2000 - 01:18:20 EST


Tom Rini wrote:
>
> On Sun, Apr 30, 2000 at 08:34:04PM +1000, Andrew Morton wrote:
>
> > - Added some powerpc #defines (John Daniel <jdaniel@etresoft.com>).
> >
> > [ We haven't heard if this works yet. ]
>
> They look totally unneeded. The driver includes asm/io.h. include/asm-ppc/io.h
> defines outsl to _outsl_ns, which is what outsl_ns is defined to as well.

Are you sure? include/asm-ppc/io.h has:

#define outsl(port, buf, nl) _outsl((u32 *)((port)+_IO_BASE), (buf),
(nl))
 
#define outsl_ns(port, buf, nl) _outsl_ns((u32 *)((port)+_IO_BASE),
(buf), (nl))
 
Whereas 3c59x now has

#define outsl outsl_ns

Which would appear to alter the behaviour...

John and Andreas are currently working on the ppc byte ordering issues
with this driver. As far as I know, it is currently in the "not known
to work on PPC" state. If you are able to debug, test or otherwise
help them sort it out it would be truly great!

-- 
-akpm-

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun May 07 2000 - 21:00:09 EST