Re: [PATCH] 2.3.99pre7-1 - From dev->resource[x].start to pci_resource_start(dev, x)

From: Jes Sorensen (Jes.Sorensen@cern.ch)
Date: Tue May 02 2000 - 13:13:24 EST


>>>>> "Jeff" == Jeff Garzik <jgarzik@mandrakesoft.com> writes:

Jeff> diff -u --recursive --new-file
Jeff> linux-2.3.99pre7-1.orig/drivers/net/acenic.c
Jeff> linux-2.3.99pre7-1/drivers/net/acenic.c
Jeff> --- linux-2.3.99pre7-1.orig/drivers/net/acenic.c Fri Apr 28
Jeff> 20:59:43 2000
Jeff> +++ linux-2.3.99pre7-1/drivers/net/acenic.c Sat Apr 29 16:23:24 2000
Jeff> @@ -497,7 +497,7 @@
Jeff> #if (LINUX_VERSION_CODE < 0x02030d)
Jeff> dev->base_addr = pdev->base_address[0];
Jeff> #else
Jeff> - dev->base_addr = pdev->resource[0].start;
Jeff> + dev->base_addr = pci_resource_start(pdev, 0);
Jeff>

Uhm no, this should go in the compat interface before you start doing
things like that.

Jeff> ** ug, this driver needs to test IORESOURCE_xxx against the
Jeff> value in dev-> resource[].flags

Why? It'll never to IO port mapping.

Jes

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun May 07 2000 - 21:00:10 EST