On Tue, 2 May 2000, Linus Torvalds wrote:
> On Mon, 1 May 2000, Tigran Aivazian wrote:
> >
> > Also, this patch can be treated as a bug fix as there are probably drivers
> > which call ioremap() without sufficient locking.
>
> Your changes to vread() look like obvious bugs to me, please tell me
> otherwise of fix them..
Hmmm, but changes to vread() are very simple - apart from
locking/unlocking vmlist_lock all we do is NOT write to userspace buffer
but instead write to a kernel buffer passed as argument:
- put_user('\0', buf);
+ *buf = '\0';
and
- put_user(*addr, buf);
+ *buf = *addr;
what is the problem? Maybe you meant changes to read_kmem() which actually
allocates a page and calls vread() - but even those look fine? What are
the obvious bugs in vread()?
Regards,
Tigran
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sun May 07 2000 - 21:00:10 EST