Urban Widmark wrote:
>
> On Wed, 3 May 2000, Jeff Garzik wrote:
>
> > The __{dev}initdata sections are rw not ro, so you cannot put const data
> > in them. Thanks for pointing this out William.
>
> pre6 has:
>
> static const char *versionA __devinitdata =
> "via-rhine.c:v1.03a-LK1.1.4 3/28/2000 Written by Donald Becker\n";
> static const char *versionB __devinitdata =
> " http://cesdis.gsfc.nasa.gov/linux/drivers/via-rhine.html\n";
>
> Is that ok, or is it just older gcc's not checking this that make it
> compile?
> Beside the via-rhine, in pre7-3:
> epic100.c, starfire.c has const version[] __devinitdata
> 3c59x.c has const *version __devinitdata
I wonder if "version[]" versus "*version" makes any difference?
It looks like all these are wrong. epic100 and starfire were recently
updated by me so I should fix that.
The problem won't show up when compiling has CONFIG_HOTPLUG or when
compiling as a module, so only non-hotplug static kernel builds will
break compiles.
Making the version strings constant or not is hardly a big issue in any
case :) As long as they are marked __{dev}initdata, they will get
dropped after kernel boot, if possible.
Jeff
-- Jeff Garzik | Nothing cures insomnia like the Building 1024 | realization that it's time to get up. MandrakeSoft, Inc. | -- random fortune- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sun May 07 2000 - 21:00:13 EST