On Wed, May 03 2000, Pete Zaitcev wrote:
> This is precisely the reason why IDE does not work on sparc(32).
> save_flags() on sparc saves a stack position (CWP register).
> If flags are passed into a function, then restore_flags() is done,
> CWP gets restored, stack frame shifted, and all local variables
> instantly corrupted with an Oops or lockup.
See previous mail, it looks as if we can avoid saving the flags
all together.
> I must admit it is fixable with a longer version of restore_flags(),
> but DaveM rejected my patch to that. See this:
> From: Pete Zaitcev <zaitcev@metabyte.com>
> Date: Tue, 3 Aug 1999 10:54:15 -0700 (PDT)
>
> which is really dumb. Let's fix the broken code.
The bug is that old?
> I certainly would welcome a change to IDE that removes passing of
> flags as an argument.
Andre, could you verify that it is good and include it?
-- * Jens Axboe <axboe@suse.de> * Linux CD/DVD-ROM, SuSE Labs * http://kernel.dk- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sun May 07 2000 - 21:00:13 EST