Re: [PATCH] pci devices initialization.

From: Jeff Garzik (jgarzik@mandrakesoft.com)
Date: Sat May 13 2000 - 14:25:30 EST


Rui Sousa wrote:
> diff -ur linux-2.3/arch/i386/kernel/acpi.c linux-2.3.new/arch/i386/kernel/acpi.c
> --- linux-2.3/arch/i386/kernel/acpi.c Thu May 11 19:39:01 2000
> +++ linux-2.3.new/arch/i386/kernel/acpi.c Fri May 12 18:39:08 2000
> @@ -824,12 +824,12 @@
> {acpi_init_via},
> };
>
> -const static struct pci_device_id acpi_pci_tbl[] =
> +const static struct pci_device_id acpi_pci_tbl[] __devinitdata =
> {

This patch breaks the build: you cannot put const data in the initdata
sections...

        Jeff

gcc -D__KERNEL__ -I/spare/cvs/linux_2_3/include -D__SMP__ -Wall
-Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strict-aliasing -pipe
-mpreferred-stack-boundary=2 -march=i686 -c -o acpi.o acpi.c
acpi.c:1670: __setup_str_acpi_setup causes a section type conflict
acpi.c:1672: acpi causes a section type conflict
make[1]: *** [acpi.o] Error 1
make[1]: Leaving directory `/spare/cvs/linux_2_3/arch/i386/kernel'
make: *** [_dir_arch/i386/kernel] Error
2

-- 
Jeff Garzik              | Liberty is always dangerous, but
Building 1024            | it is the safest thing we have.
MandrakeSoft, Inc.       |      -- Harry Emerson Fosdick

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon May 15 2000 - 21:00:23 EST