Re: [one more PATCH] Re: Old HD driver does not compile in 2.3.99pre9-2

From: Andries Brouwer (aeb@veritas.com)
Date: Mon May 22 2000 - 09:46:14 EST


On Mon, May 22, 2000 at 04:24:18PM +0200, Andrzej Krzysztofowicz wrote:

> > Since you ask:
> > New setup versus changing prototype of old one?
> > Keeping the diff small and obvious.
>
> Diff size would be rather the same. New unnecessary functions would
> not make it clearer, IMHO. Did you do this for
> any kind of "backwards compatibility" ?

Yes. But these questions are not very interesting.

You come with a problem. I look at the code and spot a flaw and fix it.
Al says "that cannot be all", and he is right, so I look at the code
again, spot another flaw and fix also that.

Now I expect from you comments telling us whether these fixes suffice,
or that further work is required. Instead you mutter about 6 versus 4 -
my source tree is not the same as yours, and my code is correct for both.
Let us fix bugs instead of quibbling.

Andries

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue May 23 2000 - 21:00:21 EST