Re: [PATCH] fix set_palette bug in console.c

From: Yuri Per (yuri@PhysTechSoft.com)
Date: Wed May 31 2000 - 06:20:28 EST


Hi!

I have tryed such change before sending my own patch. It really works.
I am not sure that such patch has no side effects on the vgacon driver.
In fact, set_palette is not required for fbcon driver at all, because
framebuffer drivers remebers palette themselves.

Yuri

jsimmons@acsu.buffalo.edu (James Simmons) wrote:
>
> This patch a bug in the VT switching code in redraw_screen in console.c.
> For most video cards you need to see the color palette after you set the
> video mode. For fbdev drivers the con_switch hook changes the video mode
> and with most of these video cards the way the palette is set depends on
> the current video mode. Please test this patch and report the results.
> Thank you.
>
> --- console.c.orig Tue May 30 10:34:02 2000
> +++ console.c Tue May 30 10:34:36 2000
> @@ -581,8 +581,8 @@
>
> if (redraw) {
> set_origin(currcons);
> - set_palette(currcons);
> if (sw->con_switch(vc_cons[currcons].d) && vcmode != KD_GRAPHICS)
> + sw->con_set_palette(vc_cons[currcons].d, color_table);
> /* Update the screen contents */
> do_update_region(currcons, origin, screenbuf_size/2);
> }
>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed May 31 2000 - 21:00:26 EST