Re: [PATCH] fix for sysinfo(2) in 2.4.0-test1

From: Erik Andersen (andersen@xmission.com)
Date: Sun Jun 04 2000 - 13:09:15 EST


On Sun Jun 04, 2000 at 06:50:54PM +0100, Alan Cox wrote:
> > > > + val.freehigh*=PAGE_SIZE;
> > >
> > > Each of these may overflow a 32bit value
> >
> > Only on 32 bit platforms that have High Memory Support enabled.
>
> Swap can overflow on any box

Ok. I hadn't considered that case. Doesn't that mean 2.2.x is broken
as well?

If we cap the returns from sysinfo to ULONG_MAX and then implement sysinfo64 so
it returns things in units of PAGE_SIZE, it won't break binaries and source
without lettting folks at lease know somthing has changed...

 -Erik

--
Erik B. Andersen   Web:    http://www.xmission.com/~andersen/ 
                   email:  andersee@debian.org
--This message was written using 73% post-consumer electrons--

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Jun 07 2000 - 21:00:19 EST