Re: Oops report on microcode.o linux-2.4.0-test1-ac11

From: H. Peter Anvin (hpa@transmeta.com)
Date: Mon Jun 12 2000 - 12:21:54 EST

Next message: Russell King: "nfs_refresh_inode: inode number mismatch with 2.4.0test1-ac15"
Previous message: Armin Kuster: "Re: devfsd-v1.3.9 available"
In reply to: Philipp Rumpf: "Re: Oops report on microcode.o linux-2.4.0-test1-ac11"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Philipp Rumpf wrote:
>
> On Sat, Jun 10, 2000 at 04:05:29PM -0700, H. Peter Anvin wrote:
> > > diff -ur linux/arch/i386/kernel/microcode.c linux-prumpf/arch/i386/kernel/microcode.c
> > > --- linux/arch/i386/kernel/microcode.c Fri Jun 9 19:05:09 2000
> > > +++ linux-prumpf/arch/i386/kernel/microcode.c Fri Jun 9 19:06:19 2000
> > > @@ -227,7 +227,7 @@
> > > }
> > >
> > > wrmsr(0x79, (unsigned int)(m->bits), 0);
> > > - __asm__ __volatile__ ("cpuid");
> > > + __asm__ __volatile__ ("cpuid" : : : "ax", "bx", "cx", "dx", "cc");
> > > rdmsr(0x8B, val[0], val[1]);
> > >
> > > req->err = 0;
> > >
> >
> > The "cc" isn't required.
>
> Who knows what the microcode update changed ? OTOH, if that is the case,
> it'd be cleaner to use one asm statement anyway.

However, the clobber terms apply to the CPUID instruction, which doesn't
alter cc.

-hpa

-- <hpa@transmeta.com> at work, <hpa@zytor.com> in private! "Unix gives you enough rope to shoot yourself in the foot." http://www.zytor.com/~hpa/puzzle.txt

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/

Next message: Russell King: "nfs_refresh_inode: inode number mismatch with 2.4.0test1-ac15"
Previous message: Armin Kuster: "Re: devfsd-v1.3.9 available"
In reply to: Philipp Rumpf: "Re: Oops report on microcode.o linux-2.4.0-test1-ac11"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Jun 15 2000 - 21:00:26 EST