ac18: arch/i386/traps.c:546: warning: `and' of mutually exclusive equal-tests is always zero

• Next message: Michael S. Fischer: "Kernel 2.2.16 oops in tcp_v4_unhash(?)"
• Previous message: Rik van Riel: "Re: strange messages from the kernel: VM: do_try..."
• Next in thread: Philipp Rumpf: "Re: ac18: arch/i386/traps.c:546: warning: `and' of mutually exclusive equal-tests is always zero"
• Reply: Philipp Rumpf: "Re: ac18: arch/i386/traps.c:546: warning: `and' of mutually exclusive equal-tests is always zero"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Compiled with silent... got a warning I have not seen previously

- if ((tsk->flags & (PF_DTRACE|PF_PTRACED)) == PF_DTRACE)
+ if ((tsk->ptrace & PT_DTRACE) && (!tsk->ptrace&PT_PTRACED))

shouldn't it be

- if ((tsk->flags & (PF_DTRACE|PF_PTRACED)) == PF_DTRACE)
+ if ((tsk->ptrace & PT_DTRACE) && !(tsk->ptrace&PT_PTRACED))

or the rather unreadable

- if ((tsk->flags & (PF_DTRACE|PF_PTRACED)) == PF_DTRACE)
+ if ((tsk->ptrace & PT_DTRACE) && (~tsk->ptrace&PT_PTRACED))

/RogerL

--
Home page:
  http://www.norran.net/nra02596/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Michael S. Fischer: "Kernel 2.2.16 oops in tcp_v4_unhash(?)"
• Previous message: Rik van Riel: "Re: strange messages from the kernel: VM: do_try..."
• Next in thread: Philipp Rumpf: "Re: ac18: arch/i386/traps.c:546: warning: `and' of mutually exclusive equal-tests is always zero"
• Reply: Philipp Rumpf: "Re: ac18: arch/i386/traps.c:546: warning: `and' of mutually exclusive equal-tests is always zero"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Jun 15 2000 - 21:00:29 EST