Re: Kernel 2.2.16 oops in tcp_v4_unhash(?)

From: Michael S. Fischer (michael@auctionwatch.com)
Date: Fri Jun 16 2000 - 14:29:12 EST

On Wednesday, 14 June 2000, kuznet@ms2.inr.ac.ru wrote:

> Hello!
>
> > We've been having problems with Linux kernels from 2.2.12 (RedHat) up
> > to 2.2.16 (stock from kernel.org) on our VA Linux 2300 series boxes.
> > This report is from a 2.2.16 kernel.
>
> Please, try this patchlet.
>
> Alexey
>
>
> --- linux/net/ipv4/tcp_ipv4.c.orig Wed Jun 14 21:21:47 2000
> +++ linux/net/ipv4/tcp_ipv4.c Wed Jun 14 21:22:06 2000
> @@ -356,7 +356,8 @@
> *sk->pprev = sk->next;
> sk->pprev = NULL;
> tcp_reg_zap(sk);
> - __tcp_put_port(sk);
> + if (sk->prev != NULL)
> + __tcp_put_port(sk);
> }
> SOCKHASH_UNLOCK();
> }

OK, this patch seems to have fixed the problem (or at least covered up
the real problem that may lie underneath). We've been back up almost
48 hours since the patch has been applied (on both RedHat 2.2.14 and
stock 2.2.16 kernels).

Thanks for your help. Hopefully we won't have bigger problems down
the line :-)

Alan, will this patch make it into 2.2.17? 

-- 
Michael S. Fischer <michael@auctionwatch.com>
Operations Team Lead, AuctionWatch.com
Phone: +1 650 808 5842
FAX:   +1 650 875 0915
"From the bricks of shame is built the hope" --Alan Wilder

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Fri Jun 23 2000 - 21:00:12 EST