Re: [patch-2.4.0-test2]Re: Linux-2.4.0-test2

From: Tigran Aivazian (tigran@veritas.com)
Date: Sat Jun 24 2000 - 12:24:49 EST


On Sat, 24 Jun 2000, Philipp Rumpf wrote:

> On Sat, Jun 24, 2000 at 06:54:24PM +0200, Urban Widmark wrote:
> > So all drivers (I'm sure there are a few) that use something like
> >
> > struct foo {
> > u32 a;
> > u32 b;
> > u32 c;
> > u32 d;
> > }
> >
> > to communicate with some hardware (4 32-bit values with addresses in
> > sequence) should be fixed not to make assumptions about the layout of a
> > struct?
>
> They should be fixed to use __attribute__((packed)). Also they shouldn't
> have any unaligned struct members.
>

are you 100% sure its needed? So all filesystems should use
__attribute__((packed)) when they describe on-disk inode/superblock
layout? none of the existing ones (except, partially, ncpfs) do.

Regards,
Tigran

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Jun 26 2000 - 21:00:04 EST